[BitVisor-devel:65] Re: device addition(BCM5720) and cannot link-up (like as PRO/1000)

[Hideki EIRAKU]

Hi,

> for BNX,
>     .pci = "device=bnx, number=0, driver=bnx, virtio=1, tty=1",
> 
> for Intel PRO/1000,
>     .pci = "device=pro1000, number=0, driver=pro1000, virtio=1, tty=1",

You need to add "net=pass" driver option if you want to connect
between a virtual port and a physical port.  If no "net" option is
specified, the driver drops all packets.

> These NICs can be camouflaged as virtio_pci device(checked with lspci
> -vvvvx), still, can not be linked-up.
> By "ip" command, the NIC state are printed as UNKNOWN.

I can reproduce the behavior.  If the driver is working properly, the
state is still UNKNOWN but the guest operating system can communicate
via the interface.  I will investigate the cause of the problem.

-- 
Hideki EIRAKU <hdk ＠ igel.co.jp>

From: Iori YONEJI <iori ＠ osss.cs.tsukuba.ac.jp>
Subject: [BitVisor-devel:64] device addition(BCM5720) and cannot link-up (like as PRO/1000)
Date: Tue, 1 Dec 2015 02:24:11 +0900

> Hello, I'm Iori Yoneji ＠ Univ.Tsukuba.
> 
> I have good news and bad news (question).
> 
> Good one. I just added a device ID of BCM5720 into device list.
> I have confirmed that it works with "tty" and "virtio" options as the
> case with PRO/1000.
> 
> Bad one. However, both of the two kind of NICs (including BCM5720
> I218-LM and I350-T2) could not been used under linux.
> These NICs can be camouflaged as virtio_pci device(checked with lspci
> -vvvvx), still, can not be linked-up.
> By "ip" command, the NIC state are printed as UNKNOWN.
> 
> The only change in the code(against 72f66eb) is device addition
> (below). Plus, I changed defconfig (as second below).
> If someone (I'm expectin' for Eiraku-san :p) know about this issue and
> fix, I'm very pleased to be informed about that.
> 
> 
> diff -r cc32c7634f7e drivers/net/bnx.c
> --- a/drivers/net/bnx.c Mon Nov 30 18:16:31 2015 +0900
> +++ b/drivers/net/bnx.c Tue Dec 01 00:43:15 2015 +0900
> @@ -993,7 +993,8 @@
>         .longname       = driver_longname,
>         .driver_options = "tty,net,virtio",
>         .device         = "class_code=020000,id="
> -                         "14e4:165a|" /* BCM5722 */
> +                         "14e4:165a|" /* BCM5720 */
> +                         "14e4:165f|" /* BCM5722 */
>                           "14e4:1682|" /* Thunderbolt - BCM57762 */
>                           "14e4:1684|" /* BCM5764M */
>                           "14e4:1686|" /* BCM57766 */
> 
> 
> +--------------------+
> 
> 
> at line 147:
> 
> for BNX,
>     .pci = "device=bnx, number=0, driver=bnx, virtio=1, tty=1",
> 
> for Intel PRO/1000,
>     .pci = "device=pro1000, number=0, driver=pro1000, virtio=1, tty=1",
> _______________________________________________
> BitVisor-devel mailing list
> BitVisor-devel ＠ bitvisor.org
> https://www.bitvisor.org/mailman/listinfo/bitvisor-devel